Github user mallman commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15125#discussion_r103509816
  
    --- Diff: docs/graphx-programming-guide.md ---
    @@ -708,7 +708,9 @@ messages remaining.
     > messaging function.  These constraints allow additional optimization 
within GraphX.
     
     The following is the type signature of the [Pregel 
operator][GraphOps.pregel] as well as a *sketch*
    -of its implementation (note calls to graph.cache have been removed):
    +of its implementation (note: to avoid stackOverflowError due to long 
lineage chains, graph and 
    --- End diff --
    
    Personally, I don't think we need to include the checkpointer in the 
implementation sketch. I think it's more an implementation detail than an 
essential part of the algorithm. I think it's enough to simply document that 
GraphX's implementation of pregel includes checkpointing to avoid unbounded RDD 
lineages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to