Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/17090
  
    @MLnick Thanks *a lot* for the detailed tests!  I really appreciate it.  In 
this case, are you OK with the approach in the current PR (pending reviews)?
    
    One thing we should confirm is what you think of the input/output schema 
for these methods.  It'd be nice to have the schema match what you think best 
for the transform-based recommendAll.
    
    Re: design: I saw the discussions in 
https://issues.apache.org/jira/browse/SPARK-13857 but I didn't see a clear 
statement of pros & cons leading to a design decision.  I'm sorry about not 
having time to get involved with the discussions, but I'd like to help out as 
useful in the coming months.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to