Github user jisookim0513 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16714#discussion_r103564868
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -64,6 +64,12 @@ private[spark] class EventLoggingListener(
private val shouldOverwrite =
sparkConf.getBoolean("spark.eventLog.overwrite", false)
private val testing = sparkConf.getBoolean("spark.eventLog.testing",
false)
private val outputBufferSize =
sparkConf.getInt("spark.eventLog.buffer.kb", 100) * 1024
+ // To reduce the size of event logs, we can omit logging all of internal
accumulables for metrics.
+ private val omitInternalAccumulables =
--- End diff --
@vanzin I added CPU time because back then I was pulling stage metrics from
history server and needed CPU time. Here's the PR for the change:
https://github.com/apache/spark/pull/10212 . Looking at the code, CPU time
should be there, so I think there's something on my end. That's a separate
problem though, and I don't think CPU time metric should increase size of event
logs much. I can't think of a use case for internal accumulables then, so I
think it makes sense to delete this. If anyone wants to use internal
accumulables for stage metrics, they should be able to catch it after a stage
finishes, not from History server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
