GitHub user brkyvz opened a pull request:

    https://github.com/apache/spark/pull/17107

    [SPARK-19774] StreamExecution should call stop() on sources when a stream 
fails

    ## What changes were proposed in this pull request?
    
    We call stop() on a Structured Streaming Source only when the stream is 
shutdown when a user calls streamingQuery.stop(). We should actually stop all 
sources when the stream fails as well, otherwise we may leak resources, e.g. 
connections to Kafka.
    
    ## How was this patch tested?
    
    Unit tests in `StreamingQuerySuite`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brkyvz/spark close-source

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17107
    
----
commit bc0833815d72cdbd32c2a3d68ab31e427304f319
Author: Burak Yavuz <[email protected]>
Date:   2017-02-28T22:52:44Z

    ready for review

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to