Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17064#discussion_r103594974
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
    @@ -634,4 +634,28 @@ class CachedTableSuite extends QueryTest with 
SQLTestUtils with SharedSQLContext
           assert(getNumInMemoryRelations(cachedPlan2) == 4)
         }
       }
    +
    +  test("refreshByPath should refresh all cached plans with the specified 
path") {
    +    def f(path: String, spark: SparkSession, dataCount: Int): DataFrame = {
    +      spark.catalog.refreshByPath(path)
    +      val data = spark.read.parquet(path)
    +      assert(data.count == dataCount)
    +      val df = data.filter("id > 10")
    +      df.cache
    +      assert(df.count == dataCount - 11)
    +      val df1 = df.filter("id > 11")
    +      df1.cache
    +      assert(df1.count == dataCount - 12)
    +      df1
    --- End diff --
    
    The function is called twice. So actually it is meant to refresh the cache 
in first call. Since I will change the test to what you suggested 
https://github.com/apache/spark/pull/17064#discussion_r103530085, we can get 
rid of this confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to