Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2393#discussion_r17533627
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TestHive.scala
---
@@ -41,7 +49,27 @@ import org.apache.spark.sql.SQLConf
import scala.collection.JavaConversions._
object TestHive
- extends TestHiveContext(new SparkContext("local[2]", "TestSQLContext",
new SparkConf()))
+ extends TestHiveContext(new SparkContext("local[2]", "TestSQLContext",
new SparkConf())) {
+
+ Signal.handle(new Signal("INT"), new SignalHandler() {
--- End diff --
Yikes, this seems a whole lot more heavy handed than just implementing test
lifecycle methods with annotations. Elsewhere in the test framework, temp
files are reliably delete by:
- Invoking the standard method to get a temp dir
- ... which calls `deleteOnExit()`
- ... which also cleans up the declared test dir in an annotated cleanup
method
I would really avoid use of `Signal`! It does not seem required and is
inconsistent with other tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
