Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/17056
@gatorsmile : I really appreciate your help in reviewing this PR to the
extent that you are manually checking the hashes over Hive. If you haven't
already embarked on that, here is the set of hive queries corresponding to the
test case in the PR which you can easily copy paste:
```
SELECT HASH(CAST(18BD AS DECIMAL(38, 0)));
SELECT HASH(CAST(-18BD AS DECIMAL(38, 0)));
SELECT HASH(CAST(-18BD AS DECIMAL(38, 12)));
SELECT HASH(CAST(18446744073709001000BD AS DECIMAL(38, 19)));
SELECT HASH(CAST(-18446744073709001000BD AS DECIMAL(38, 22)));
SELECT HASH(CAST(-18446744073709001000BD AS DECIMAL(38, 3)));
SELECT HASH(CAST(18446744073709001000BD AS DECIMAL(38, 4)));
SELECT HASH(CAST(9223372036854775807BD AS DECIMAL(38, 4)));
SELECT HASH(CAST(-9223372036854775807BD AS DECIMAL(38, 5)));
SELECT HASH(CAST(00000.00000000000BD AS DECIMAL(38, 34)));
SELECT HASH(CAST(-00000.00000000000BD AS DECIMAL(38, 11)));
SELECT HASH(CAST(123456.1234567890BD AS DECIMAL(38, 2)));
SELECT HASH(CAST(123456.1234567890BD AS DECIMAL(38, 20)));
SELECT HASH(CAST(123456.1234567890BD AS DECIMAL(38, 10)));
SELECT HASH(CAST(-123456.1234567890BD AS DECIMAL(38, 10)));
SELECT HASH(CAST(123456.1234567890BD AS DECIMAL(38, 0)));
SELECT HASH(CAST(-123456.1234567890BD AS DECIMAL(38, 0)));
SELECT HASH(CAST(123456.1234567890BD AS DECIMAL(38, 20)));
SELECT HASH(CAST(-123456.1234567890BD AS DECIMAL(38, 20)));
SELECT HASH(CAST(123456.123456789012345678901234567890BD AS DECIMAL(38,
0)));
SELECT HASH(CAST(-123456.123456789012345678901234567890BD AS DECIMAL(38,
0)));
SELECT HASH(CAST(123456.123456789012345678901234567890BD AS DECIMAL(38,
10)));
SELECT HASH(CAST(-123456.123456789012345678901234567890BD AS DECIMAL(38,
10)));
SELECT HASH(CAST(123456.123456789012345678901234567890BD AS DECIMAL(38,
20)));
SELECT HASH(CAST(-123456.123456789012345678901234567890BD AS DECIMAL(38,
20)));
SELECT HASH(CAST(123456.123456789012345678901234567890BD AS DECIMAL(38,
30)));
SELECT HASH(CAST(-123456.123456789012345678901234567890BD AS DECIMAL(38,
30)));
SELECT HASH(CAST(123456.123456789012345678901234567890BD AS DECIMAL(38,
31)));
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
