Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17059#discussion_r103675924
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -451,8 +461,8 @@ class ALS(@Since("1.4.0") override val uid: String)
extends Estimator[ALSModel]
val r = if ($(ratingCol) != "") col($(ratingCol)).cast(FloatType) else
lit(1.0f)
val ratings = dataset
- .select(checkedCast(col($(userCol)).cast(DoubleType)),
- checkedCast(col($(itemCol)).cast(DoubleType)), r)
+ .select(checkedCast(col($(userCol))),
+ checkedCast(col($(itemCol))), r)
--- End diff --
Nit - but can this now go on one line if short enough?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
