Github user skambha commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17067#discussion_r103756083
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
    @@ -52,6 +52,19 @@ abstract class SQLViewSuite extends QueryTest with 
SQLTestUtils {
         }
       }
     
    +  test("column resolution scenarios with local temp view") {
    +    val df = Seq(2).toDF("i1")
    +    df.createOrReplaceTempView("table1")
    +    withTempView("table1") {
    +      checkAnswer(spark.sql("SELECT table1.* FROM table1"), Row(2))
    +      checkAnswer(spark.sql("SELECT * FROM table1"), Row(2))
    +      checkAnswer(spark.sql("SELECT i1 FROM table1"), Row(2))
    +      checkAnswer(spark.sql("SELECT table1.i1 FROM table1"), Row(2))
    +      checkAnswer(spark.sql("SELECT a.i1 FROM table1 AS a"), Row(2))
    +      checkAnswer(spark.sql("SELECT i1 FROM table1 AS a"), Row(2))
    --- End diff --
    
    Hi Xiao,  I have moved my new local temp view tests and the global temp 
view tests to the SQLQueryTestSuite framework as well.  Please take a look. 
Thanks. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to