Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103849859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -202,14 +194,9 @@ trait CheckAnalysis extends PredicateHelper {
s"filter expression '${f.condition.sql}' " +
s"of type ${f.condition.dataType.simpleString} is not a
boolean.")
- case f @ Filter(condition, child) =>
- splitConjunctivePredicates(condition).foreach {
- case _: PredicateSubquery | Not(_: PredicateSubquery) =>
- case e if
PredicateSubquery.hasNullAwarePredicateWithinNot(e) =>
- failAnalysis(s"Null-aware predicate sub-queries cannot be
used in nested" +
- s" conditions: $e")
- case e =>
- }
+ case Filter(condition, _) if
SubExprUtils.hasNullAwarePredicateWithinNot(condition) =>
+ failAnalysis(s"Null-aware predicate sub-queries cannot be used
in nested" +
+ s" conditions: $condition")
--- End diff --
Nit: `s"` -> `"` and move the space from the beginning of the second line
to the end of the first line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
