Github user windpiger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17095#discussion_r103863691
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
 ---
    @@ -254,7 +254,18 @@ class SessionCatalog(
         val db = 
formatDatabaseName(tableDefinition.identifier.database.getOrElse(getCurrentDatabase))
         val table = formatTableName(tableDefinition.identifier.table)
         validateName(table)
    -    val newTableDefinition = tableDefinition.copy(identifier = 
TableIdentifier(table, Some(db)))
    +
    +    val newTableDefinition = if 
(tableDefinition.storage.locationUri.isDefined) {
    --- End diff --
    
    Yes, they should all be applied this logic~
     database has already contain this logic, shall I add the logic of 
partition in another pr?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to