Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17124#discussion_r103864707
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
 ---
    @@ -282,8 +282,12 @@ private[state] class HDFSBackedStateStoreProvider(
           // target file will break speculation, skipping the rename step is 
the only choice. It's still
           // semantically correct because Structured Streaming requires 
rerunning a batch should
           // generate the same output. (SPARK-19677)
    +      // Also, a tmp file of delta file that generated by the first batch 
after restart
    --- End diff --
    
    This comment is not 100% correct, this may also happen in a speculation 
task.
    
    This PR is just a follow up to delete the temp file that #17012 forgot to 
do it. IMO, not need to add a comment for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to