Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16610#discussion_r103879925
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -91,15 +91,22 @@ object functions {
* @group normal_funcs
* @since 1.3.0
*/
- def lit(literal: Any): Column = {
- literal match {
- case c: Column => return c
- case s: Symbol => return new
ColumnName(literal.asInstanceOf[Symbol].name)
- case _ => // continue
- }
+ def lit(literal: Any): Column = typedLit(literal)
- val literalExpr = Literal(literal)
- Column(literalExpr)
+ /**
+ * Creates a [[Column]] of literal value.
+ *
+ * The passed in object is returned directly if it is already a
[[Column]].
+ * If the object is a Scala Symbol, it is converted into a [[Column]]
also.
+ * Otherwise, a new [[Column]] is created to represent the literal value.
+ *
+ * @group normal_funcs
+ * @since 2.2.0
+ */
+ def typedLit[T : TypeTag](literal: T): Column = literal match {
--- End diff --
cc @cloud-fan wdyt about the naming?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
