Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103891636
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.assertAnalyzed()
val analyzedPlan = qe.analyzed
+ // CREATE VIEW AS INSERT INTO ... is not allowed, we should throw an
AnalysisException.
+ analyzedPlan match {
+ case i: InsertIntoHadoopFsRelationCommand =>
--- End diff --
Hmmm... fixing this in grammar itself would a little bit of work (we also
support multi-insert and that makes this harder). I suppose we could try to add
a check in the `AstBuilder`.
Why not check this in the `CreateViewCommand`? That seems safer to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
