Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1486#discussion_r17560907
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
    @@ -309,4 +323,42 @@ private[spark] object HadoopRDD {
           f(inputSplit, firstParent[T].iterator(split, context))
         }
       }
    +
    +  private[spark] class SplitInfoReflections {
    --- End diff --
    
    the way this is factored exposes a bunch of stuff at `private[spark]` 
visibility that is really specific to the internals of `HadoopRDD`. What about 
just adding a single static utility function in `HadoopRDD`:
    
    ```
    /*** Return a correctly formatted set of location strings for a 
HadoopPartition. */
    private[spark] def getLocationPreferences(partition: HadoopPartition): 
Seq[String] {
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to