Github user AnthonyTruchet commented on the issue:
https://github.com/apache/spark/pull/14299
The blocking flag is not the issue.
The issue is that there was not try / finally and the destruction was only
done if the fitting succeded and skipped otherwise.
In this PR I move the destruction into a try / finally construct, all the
while extracting the actual fitting into a dedicated method to keep nesting
under control.
Whether the destruction should be blocking or not is pretty debatable and I
do not have any strong mind on the question, I choose to make them blocking
"just to be sure" this is actually performed. If you'd rather keep the non
blocking best effort current behaviour I'll perform the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
