Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17133#discussion_r104007448
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -695,7 +695,8 @@ private[spark] class TaskSetManager(
def handleSuccessfulTask(tid: Long, result: DirectTaskResult[_]): Unit =
{
val info = taskInfos(tid)
val index = info.index
- info.markFinished(TaskState.FINISHED)
+ // Mark task as finished. Note that finishing time here should be
bigger than 0.
--- End diff --
I'm not sure what this comment is trying to say, especially since there's
no check anywhere for "finishing time > 0" in the code here.
Also, grammar nit: it should be "larger than 0".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
