Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17114#discussion_r104114853
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/inline-table.sql ---
    @@ -29,6 +29,9 @@ select * from values ("one", array(0, 1)), ("two", 
array(2, 3)) as data(a, b);
     -- decimal and double coercion
     select * from values ("one", 2.0), ("two", 3.0D) as data(a, b);
     
    +-- string to timestamp
    +select * from values timestamp('1991-12-06 00:00:00.0') as data(a);
    --- End diff --
    
    Could you put this at the end of the file? That reduces the size of the 
diff.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to