GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/17151
[ML][Minor] Separate estimator and model params for read/write test.
## What changes were proposed in this pull request?
Since we allow ```Estimator``` and ```Model``` not always share same params
(see ```ALSParams``` and ```ALSModelParams```), we should pass in test params
for estimator and model separately for ```testEstimatorAndModelReadWrite```.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark test-rw
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17151
----
commit efff28b802c6a08058b49745d0e73783302c817f
Author: Yanbo Liang <[email protected]>
Date: 2017-03-03T13:55:34Z
Separate estimator and model params for read/write test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
