Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17148#discussion_r104280865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -469,22 +487,28 @@ case class FilterEstimation(plan: Filter,
catalystConf: CatalystConf) extends Lo
val newValue = convertBoundValue(attr.dataType, literal.value)
var newMax = colStat.max
var newMin = colStat.min
+ var newNdv = (ndv * percent).setScale(0,
RoundingMode.HALF_UP).toBigInt()
+ if (newNdv < 1) newNdv = 1
+
op match {
- case _: GreaterThan => newMin = newValue
- case _: GreaterThanOrEqual => newMin = newValue
- case _: LessThan => newMax = newValue
- case _: LessThanOrEqual => newMax = newValue
+ case _: GreaterThan =>
+ if (newNdv == 1) newMin = newMax else newMin = newValue
--- End diff --
if the new ndv is 1, then new max and new min must be equal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
