Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/2397#issuecomment-55686030
  
    To me the only important issue here is the laziness semantics of `CACHE 
TABLE AS SELECT`. I tend to make it lazy because `SQLContext.cacheTable`, 
`CACHE TABLE <name>` are both lazy. Making all three eager also seems 
acceptable, but this kinda breaks downward compatibility (or at least breaks 
existing performance assumptions of caching functions/statements).
    
    Otherwise LGTM except minor issues mentioned in the comments and the 
laziness semantics of the create.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to