Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16867#discussion_r104352237 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -754,7 +743,6 @@ private[spark] class TaskSetManager( } removeRunningTask(tid) info.markFinished(state) - successfulTaskIdsSet -= tid --- End diff -- Not handling task failure will cause other issues - we need to keep data structures consistent - cost is secondary to correctness for a performance PR.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org