Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16793#discussion_r103533408
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1307,43 +1309,75 @@ def replace(self, to_replace, value, subset=None):
|null| null|null|
+----+------+----+
"""
- if not isinstance(to_replace, (float, int, long, basestring, list,
tuple, dict)):
+ # Helper functions
+ def all_of(types):
+ """Given a type or tuple of types
--- End diff --
The formatting of this docstring seems odd here. Also I'd clarify that
all_of returns a function which you can use for the check rather than it doing
the check its self.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
