Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/17152#discussion_r104459690
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
@@ -609,12 +609,25 @@ abstract class SQLViewSuite extends QueryTest with
SQLTestUtils {
}
}
- // TODO: Check for cyclic view references on ALTER VIEW.
- ignore("correctly handle a cyclic view reference") {
- withView("view1", "view2") {
+ test("correctly handle a cyclic view reference") {
+ withView("view1", "view2", "view3") {
sql("CREATE VIEW view1 AS SELECT * FROM jt")
sql("CREATE VIEW view2 AS SELECT * FROM view1")
- intercept[AnalysisException](sql("ALTER VIEW view1 AS SELECT * FROM
view2"))
+ sql("CREATE VIEW view3 AS SELECT * FROM view2")
+
+ // Detect cyclic view reference on ALTER VIEW.
+ val e1 = intercept[AnalysisException] {
+ sql("ALTER VIEW view1 AS SELECT * FROM view2")
+ }.getMessage
+ assert(e1.contains("Recursive view `default`.`view1` detected
(cycle: `default`.`view1` " +
+ "-> `default`.`view2` -> `default`.`view1`)"))
+
+ // Detect the most left cycle when there exists multiple cyclic view
references.
+ val e2 = intercept[AnalysisException] {
+ sql("ALTER VIEW view1 AS SELECT * FROM view3 JOIN view2")
+ }.getMessage
+ assert(e2.contains("Recursive view `default`.`view1` detected
(cycle: `default`.`view1` " +
+ "-> `default`.`view3` -> `default`.`view2` -> `default`.`view1`)"))
--- End diff --
How about this test case?
`sql("alter view v1 as select * from jt where exists (select 1 from v2)")`
Should we get the same exception as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
