Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r104468446
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -206,6 +206,21 @@ trait CodegenSupport extends SparkPlan {
def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: ExprCode):
String = {
throw new UnsupportedOperationException
}
+
+ /**
+ * For optimization to suppress shouldStop() in a loop of
WholeStageCodegen.
+ * Returning true means we need to insert shouldStop() into the loop
producing rows, if any.
+ */
+ def isShouldStopRequired: Boolean = {
+ return shouldStopRequired && !(this.parent != null &&
!this.parent.isShouldStopRequired)
+ }
+
+ /**
+ * Set to false if this plan consumes all rows produced by children but
doesn't output row
+ * to buffer by calling append(), so the children don't require
shouldStop()
+ * in the loop of producing rows.
+ */
+ protected def shouldStopRequired: Boolean = true
--- End diff --
How would sort be improved? Sort is very expensive operation, so it
dominates the runtime of the job. The only possible improvement here is that
you could avoid sorting with range (assuming that we do not overflow).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
