Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17186#discussion_r104665124
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala 
---
    @@ -135,7 +136,8 @@ object EliminateOuterJoin extends Rule[LogicalPlan] 
with PredicateHelper {
       }
     
       def apply(plan: LogicalPlan): LogicalPlan = plan transform {
    -    case f @ Filter(condition, j @ Join(_, _, RightOuter | LeftOuter | 
FullOuter, _)) =>
    +    case f @ Filter(condition, j @ Join(_, _, RightOuter | LeftOuter | 
FullOuter, _))
    +        if conf.constraintPropagationEnabled =>
    --- End diff --
    
    This is far to restrictive. We can still eliminate outer joins without 
constraint propagation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to