Github user zivanfi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16781#discussion_r104673553
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/ParquetHiveCompatibilitySuite.scala
 ---
    @@ -137,8 +141,190 @@ class ParquetHiveCompatibilitySuite extends 
ParquetCompatibilityTest with TestHi
       }
     
       test("SPARK-16344: array of struct with a single field named 
'array_element'") {
    +
         testParquetHiveCompatibility(
           Row(Seq(Row(1))),
           "ARRAY<STRUCT<array_element: INT>>")
       }
    +
    +  test(s"SPARK-12297: Parquet Timestamp & Hive timezone") {
    --- End diff --
    
    I think it would be better to have separate test cases for adjustments when 
reading, adjustments when writing and setting the table property when creating 
tables.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to