Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15009#discussion_r104674280
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
    @@ -78,9 +78,9 @@
     
       public static final String LAUNCHER_INTERNAL_CHILD_PROCESS_SECRET = 
"spark.launcher.internal.secret";
     
    -  public static final String LAUNCHER_INTERNAL_STOP_IF_SHUTDOWN = 
"spark.launcher.internal.stop.if.shutdown";
    +  public static final String LAUNCHER_INTERNAL_STOP_ON_SHUTDOWN = 
"spark.launcher.internal.stop.on.shutdown";
     
    -  public static final String LAUNCHER_INTERNAL_THREAD_ENABLED = 
"spark.launcher.internal.thread.enabled";
    +  public static final String LAUNCHER_INTERNAL_USE_THREAD = 
"spark.launcher.internal.use.thread";
    --- End diff --
    
    I dont' think we need these at all anymore


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to