Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/17178#discussion_r104738375
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -1342,28 +1342,52 @@ test_that("column functions", {
df <- read.json(mapTypeJsonPath)
j <- collect(select(df, alias(to_json(df$info), "json")))
expect_equal(j[order(j$json), ][1], "{\"age\":16,\"height\":176.5}")
- df <- as.DataFrame(j)
- schema <- structType(structField("age", "integer"),
- structField("height", "double"))
- s <- collect(select(df, alias(from_json(df$json, schema), "structcol")))
- expect_equal(ncol(s), 1)
- expect_equal(nrow(s), 3)
- expect_is(s[[1]][[1]], "struct")
- expect_true(any(apply(s, 1, function(x) { x[[1]]$age == 16 } )))
-
- # passing option
- df <- as.DataFrame(list(list("col" = "{\"date\":\"21/10/2014\"}")))
- schema2 <- structType(structField("date", "date"))
- expect_error(tryCatch(collect(select(df, from_json(df$col, schema2))),
- error = function(e) { stop(e) }),
- paste0(".*(java.lang.NumberFormatException: For input
string:).*"))
- s <- collect(select(df, from_json(df$col, schema2, dateFormat =
"dd/MM/yyyy")))
- expect_is(s[[1]][[1]]$date, "Date")
- expect_equal(as.character(s[[1]][[1]]$date), "2014-10-21")
-
- # check for unparseable
- df <- as.DataFrame(list(list("a" = "")))
- expect_equal(collect(select(df, from_json(df$a, schema)))[[1]][[1]], NA)
+
+ schemas <- list(structType(structField("age", "integer"),
structField("height", "double")),
+ "struct<age:integer,height:double>")
--- End diff --
oh to clarify
it might be ok if this is well documented and well checked. -> if it's
something we could formally document it might be ok
checkType in schema.R is strangely largely unused or untested though. -> I
don't know the string specification is actually accidental - I see no use of it
outside of checkType and it's not referenced anywhere. It's definitely not
being tested as well
Actually, on 2nd thought, I recall there's a JIRA on accepting the JSON
string as schema that is supported on Scala side. That might be a better way to
go if we are to take a string, instead of inventing our own format. But that
could be a bigger change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
