Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r104763900
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1048,7 +1065,7 @@ private[spark] class BlockManager(
try {
replicate(blockId, bytesToReplicate, level, remoteClassTag)
} finally {
- bytesToReplicate.dispose()
+ bytesToReplicate.unmap()
--- End diff --
one new thought: ideally we only wanna dispose bytes returned by
`DiskStore`. `ChunkedByteBuffer` has a boolean flag, `disposed`. If this flag
is true, `ChunkedByteBuffer.dispose` will become no-op.
When `MemoryStore` returns a `ChunkedByteBuffer`, how about we setting the
`disposed` flag to true? Then we won't dispose it later.`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
