Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1486#discussion_r17612925
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -181,8 +181,24 @@ private[spark] class TaskSetManager(
         }
     
         for (loc <- tasks(index).preferredLocations) {
    -      for (execId <- loc.executorId) {
    -        addTo(pendingTasksForExecutor.getOrElseUpdate(execId, new 
ArrayBuffer))
    +      loc match {
    +        case e : ExecutorCacheTaskLocation =>
    --- End diff --
    
    Should be `case e: ExecutorCacheTaskLocation` - the spacing around colons 
is off in a bunch of places in this patch, so maybe do an inventory on it. It 
should also be zzero spaces before and one space after.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to