GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/17196
[SPARK-19855][SQL] Create an internal FilePartitionStrategy interface
## What changes were proposed in this pull request?
The way we currently do file partitioning strategy is hard coded in
FileSourceScanExec. This is not ideal for two reasons:
1. It is difficult to unit test the default strategy. In order to test
this, we need to do almost end-to-end tests by creating actual files on the
file system.
2. It is difficult to experiment with different partitioning strategies
without adding a lot of if branches.
This patch introduces an internal interface for this so we can make this
pluggable for both better testing and experimentation.
## How was this patch tested?
The change should be covered by integration test cases in
FileSourceStrategySuite. A follow-up patch (tracked via SPARK-19856) will
change the partitioning related test cases in FileSourceStrategySuite from
integration tests into unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark SPARK-19855
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17196
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
