Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55777417
@mateiz Will do. There's one catch. Since `Duration` has an accessor named
`milliseconds`, and has a private accessor called `millis` from the
constructor, I can't create `Duration.milliseconds` or `Duration.millis`. I
could just omit this particular helper as it's pretty redundant with the
constructor?
I'll also add tests, and give `Time` a similar treatment with Java-friendly
names, and tests.
(PS the scalastyle checks fail because there appear to be binary operators
without surrounding space. I believe it's necessary to disable the checks in
that section of declarations, since they're not actually usages of a binary
operator.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
