Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17096#discussion_r104856634
--- Diff: python/pyspark/ml/tests.py ---
@@ -320,6 +320,13 @@ def test_hasparam(self):
testParams = TestParams()
self.assertTrue(all([testParams.hasParam(p.name) for p in
testParams.params]))
self.assertFalse(testParams.hasParam("notAParameter"))
+ self.assertTrue(testParams.hasParam(u"maxIter"))
+
+ def test_resolveparam(self):
+ testParams = TestParams()
+ self.assertEqual(testParams._resolveParam(testParams.maxIter),
testParams.maxIter)
+ self.assertEqual(testParams._resolveParam("maxIter"),
testParams.maxIter)
+ self.assertEqual(testParams._resolveParam(u"maxIter"),
testParams.maxIter)
--- End diff --
Yes, I think that makes sense, though. It seems that requires more look and
tests. I believe the current state resolves the specific JIRA. Maybe, could we
merge this as is if you are think either way is fine? I feel It has been
dragged by related changes and hope it could be merged if it is okay to you. If
it dose not sound good to you, then, let me try to take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
