Github user zero323 commented on the issue: https://github.com/apache/spark/pull/17170 @felixcheung I think i addressed all the issues excluding `inputCol` and `predictionCol`. In general: - Using `formula`as an input doesn't make sense in my opinion. - Personally I would allow users to set column names. Both `features` and `prediction` are a bit vague in the context of the algorithm.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org