Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17120#discussion_r105047840
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -75,7 +77,7 @@ class FileStreamSource(
/** A mapping from a file that we have processed to some timestamp it
was last modified. */
// Visible for testing and debugging in production.
- val seenFiles = new SeenFilesMap(sourceOptions.maxFileAgeMs)
+ val seenFiles = new SeenFilesMap(sourceOptions.maxFileAgeMs,
sourceOptions.fileNameOnly)
--- End diff --
It's better to add a warning when `fileNameOnly` is true. How about
```
logWarning("fileNameOnly is enabled. Make user your file names are unique
(e.g., using UUID), otherwise, files using the same name will be considered as
the same file and causes data lost")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
