Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17202#discussion_r105005343
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -576,6 +576,11 @@ class Dataset[T] private[sql](
val parsedDelay =
Option(CalendarInterval.fromString("interval " + delayThreshold))
.getOrElse(throw new AnalysisException(s"Unable to parse time
delay '$delayThreshold'"))
+ val delayMs = {
--- End diff --
I guess you copied these codes from `EventTimeWatermarkExec`. Could you
extract them as a new method in `object EventTimeWatermark` and reuse it?
Since you are touching these files, could you also fix the following two
places as well?
-
https://github.com/apache/spark/blob/d8830c5039d9c7c5ef03631904c32873ab558e22/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/EventTimeWatermark.scala#L42
doesn't use the correct `delayMs`. Right now we don't use this value in the
logical plan, but it's better to make it consistent.
- I forgot to update `EventTimeWatermarkExec` in #17199. Could you help me
fix it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
