Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17189#discussion_r105081718
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala 
---
    @@ -577,13 +582,17 @@ private[deploy] class Worker(
         val shouldCleanup = finishedApps.contains(id) && 
!executors.values.exists(_.appId == id)
         if (shouldCleanup) {
           finishedApps -= id
    -      appDirectories.remove(id).foreach { dirList =>
    -        logInfo(s"Cleaning up local directories for application $id")
    -        dirList.foreach { dir =>
    -          Utils.deleteRecursively(new File(dir))
    +      cleanupApplicationThreadExecutor.submit(new Runnable {
    --- End diff --
    
    That won't become an issue. The worst case is there will be some pending 
tasks in the queue of `cleanupThreadExecutor`. Considering the number of 
applications is not huge, it won't be an issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to