Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17188#discussion_r105343821
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
 ---
    @@ -69,7 +69,8 @@ object JavaTypeInference {
        * @param typeToken Java type
        * @return (SQL data type, nullable)
        */
    -  private def inferDataType(typeToken: TypeToken[_]): (DataType, Boolean) 
= {
    +  private def inferDataType(typeToken: TypeToken[_], seenTypeSet: 
Set[Class[_]] = Set.empty)
    --- End diff --
    
    You mean this case?
    ```
    
    scala> :paste
    case class classA(i: Int, cls: classB)
    case class classB(cls: classA)
    
    scala> Seq(classA(0, null)).toDS()
    java.lang.StackOverflowError
      at scala.reflect.internal.Symbols$Symbol.info(Symbols.scala:1494)
      at 
scala.reflect.runtime.JavaMirrors$JavaMirror$$anon$1.scala$reflect$runtime$SynchronizedSymbols$SynchronizedSymbol$$super$info(JavaMirrors.scala:66)
      at 
scala.reflect.runtime.SynchronizedSymbols$SynchronizedSymbol$$anonfun$info$1.apply(SynchronizedSymbols.scala:127)
      at 
scala.reflect.runtime.SynchronizedSymbols$SynchronizedSymbol$$anonfun$info$1.apply(SynchronizedSymbols.scala:127)
      at scala.reflect.runtime.Gil$class.gilSynchronized(Gil.scala:19)
      at 
scala.reflect.runtime.JavaUniverse.gilSynchronized(JavaUniverse.scala:16)
      at 
scala.reflect.runtime.SynchronizedSymbols$SynchronizedSymbol$class.gilSynchronizedIfNotThreadsafe(SynchronizedSymbols.scala:123)
      at 
scala.reflect.runtime.JavaMirrors$JavaMirror$$anon$1.gilSynchronizedIfNotThreadsafe(JavaMirrors.scala:66)
      at 
scala.reflect.runtime.SynchronizedSymbols$SynchronizedSymbol$class.info(SynchronizedSymbols.scala:127)
      at 
scala.reflect.runtime.JavaMirrors$JavaMirror$$anon$1.info(JavaMirrors.scala:66)
      at 
scala.reflect.internal.Mirrors$RootsBase.getModuleOrClass(Mirrors.scala:48)
      at 
scala.reflect.internal.Mirrors$RootsBase.getModuleOrClass(Mirrors.scala:45)
      at 
scala.reflect.internal.Mirrors$RootsBase.getModuleOrClass(Mirrors.scala:45)
      at 
scala.reflect.internal.Mirrors$RootsBase.getModuleOrClass(Mirrors.scala:45)
      at 
scala.reflect.internal.Mirrors$RootsBase.getModuleOrClass(Mirrors.scala:45)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to