Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105545712
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2897,6 +2898,27 @@ test_that("Collect on DataFrame when NAs exists at
the top of a timestamp column
expect_equal(class(ldf3$col3), c("POSIXct", "POSIXt"))
})
+compare_list <- function(list1, list2) {
+ # get testthat to show the diff by first making the 2 lists equal in
length
+ expect_equal(length(list1), length(list2))
+ l <- max(length(list1), length(list2))
--- End diff --
the idea is to show enough information from the log without having to rerun
the check manually.
the first check will show the numeric values but it wouldn't say how
exactly they are different.
the next check (or moved to compare_list() here) will get testthat to dump
the delta too, but first it must set the 2 lists into the same size etc..
in fact, all of these are well tested in "Check masked functions" test in
test_context.R, just duplicated here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
