Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17087#discussion_r105598641
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -20,20 +20,22 @@ package org.apache.spark.sql.catalyst.expressions
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.analysis.TypeCheckResult
import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext,
ExprCode}
+import org.apache.spark.sql.catalyst.expressions.codegen.{Predicate =>
GenPredicate}
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.catalyst.util.TypeUtils
import org.apache.spark.sql.types._
object InterpretedPredicate {
- def create(expression: Expression, inputSchema: Seq[Attribute]):
(InternalRow => Boolean) =
+ def create(expression: Expression, inputSchema: Seq[Attribute]):
InterpretedPredicate =
create(BindReferences.bindReference(expression, inputSchema))
- def create(expression: Expression): (InternalRow => Boolean) = {
- (r: InternalRow) => expression.eval(r).asInstanceOf[Boolean]
- }
+ def create(expression: Expression): InterpretedPredicate = new
InterpretedPredicate(expression)
}
+class InterpretedPredicate(expression: Expression) extends GenPredicate {
--- End diff --
First, this change is necessary to return `Predicate` for
`InterpretedPredicate`.
For `GenPredicate`, I used the same naming convention in `SparkPlan.scala`.
If we use `Predicate`, we will have a conflict with others. What name would it
be better instead of `GenPredicate`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
