Github user budde commented on the issue:
https://github.com/apache/spark/pull/17250
@brkyvz Thanks for taking a look!
Re: major feedback:
1. Sounds reasonable to me. I don't have strong feeling here.
1. Will do.
1. Sounds good.
1. I agree that method overloading isn't a great and could lead to a
similar scenario as ```KinesisUtils.createStream()``` in the long run. I kept
it here since I figured that the scope was rather limited and I wanted to avoid
having to deal with too many builders but I think you raise a good point. I'll
look into adding a credentials builder. Ideally we would only have to worry
about Java/Python interoperability and could just use a single method optionals
or default args to solve this but I guess we have to play the hands we're dealt
:)
I can move the builder to the companion object of ```KinesisInputDStream```
(this is actually where I had this placed originally). I like the idea of the
private constructor as well although I don't think this will be possible until
```KinesisUtils.createStream()``` is refactored to use the builder pattern.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
