Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17255#discussion_r105942833
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonInferSchema.scala
---
@@ -40,18 +40,11 @@ private[sql] object JsonInferSchema {
json: RDD[T],
configOptions: JSONOptions,
createParser: (JsonFactory, T) => JsonParser): StructType = {
- require(configOptions.samplingRatio > 0,
- s"samplingRatio (${configOptions.samplingRatio}) should be greater
than 0")
val shouldHandleCorruptRecord = configOptions.permissive
val columnNameOfCorruptRecord = configOptions.columnNameOfCorruptRecord
- val schemaData = if (configOptions.samplingRatio > 0.99) {
- json
- } else {
- json.sample(withReplacement = false, configOptions.samplingRatio, 1)
- }
--- End diff --
Yah, perhaps the RDD->Dataset changes should be done under a separate
issue. I think it can be done across the board (removing most/all RDD
references) but I'm not sure what other implications it would have.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
