Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17109#discussion_r106052638
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
 ---
    @@ -99,6 +99,26 @@ private[mesos] object MesosSchedulerBackendUtil extends 
Logging {
         .toList
       }
     
    +  /**
    +   * Parse a list of docker parameters, each of which
    +   * takes the form key=value
    +   */
    +  private def parseParamsSpec(params: String): List[Parameter] = {
    +    params.split(",").map(_.split("=")).flatMap { spec: Array[String] =>
    --- End diff --
    
    I am not very familiar with docker parameters - but wont this method not 
fail if '=' exists in the value ?
    Or is that prohibited by docker ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to