Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17216#discussion_r106059371
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala ---
    @@ -389,6 +392,102 @@ class StreamSuite extends StreamTest {
         query.stop()
         assert(query.exception.isEmpty)
       }
    +
    +  test("SPARK-19873: streaming aggregation with change in number of 
partitions") {
    +    val inputData = MemoryStream[(Int, Int)]
    +    val agg = inputData.toDS().groupBy("_1").count()
    +
    +    testStream(agg, OutputMode.Complete())(
    +      AddData(inputData, (1, 0), (2, 0)),
    +      StartStream(additionalConfs = Map(SQLConf.SHUFFLE_PARTITIONS.key -> 
"2")),
    +      CheckAnswer((1, 1), (2, 1)),
    +      StopStream,
    +      AddData(inputData, (3, 0), (2, 0)),
    +      StartStream(additionalConfs = Map(SQLConf.SHUFFLE_PARTITIONS.key -> 
"5")),
    +      CheckAnswer((1, 1), (2, 2), (3, 1)),
    +      StopStream,
    +      AddData(inputData, (3, 0), (1, 0)),
    +      StartStream(additionalConfs = Map(SQLConf.SHUFFLE_PARTITIONS.key -> 
"1")),
    +      CheckAnswer((1, 2), (2, 2), (3, 2)))
    +  }
    +
    +  test("SPARK-19873: backward compatibility - recover from a Spark v2.1 
checkpoint") {
    --- End diff --
    
    This is not directly tied to SPARK-19873. remove SPARK-19873. just "recover 
from a Spark v2.1 checkpoint"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to