Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r17652889
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/BlockServer.scala ---
@@ -121,18 +91,18 @@ class BlockServer(conf: NettyConfig, dataProvider:
BlockDataProvider) extends Lo
bootstrap.option[java.lang.Integer](ChannelOption.SO_BACKLOG,
backLog)
}
conf.receiveBuf.foreach { receiveBuf =>
- bootstrap.option[java.lang.Integer](ChannelOption.SO_RCVBUF,
receiveBuf)
+ bootstrap.childOption[java.lang.Integer](ChannelOption.SO_RCVBUF,
receiveBuf)
}
conf.sendBuf.foreach { sendBuf =>
- bootstrap.option[java.lang.Integer](ChannelOption.SO_SNDBUF, sendBuf)
+ bootstrap.childOption[java.lang.Integer](ChannelOption.SO_SNDBUF,
sendBuf)
}
bootstrap.childHandler(new ChannelInitializer[SocketChannel] {
override def initChannel(ch: SocketChannel): Unit = {
ch.pipeline
- .addLast("frameDecoder", new LineBasedFrameDecoder(1024)) //
max block id length 1024
- .addLast("stringDecoder", new StringDecoder(CharsetUtil.UTF_8))
- .addLast("blockHeaderEncoder", new BlockHeaderEncoder)
+ .addLast("frameDecoder", ProtocolUtils.createFrameDecoder())
+ .addLast("clientRequestDecoder", new ClientRequestDecoder)
+ .addLast("serverResponseEncoder", new ServerResponseEncoder)
.addLast("handler", new BlockServerHandler(dataProvider))
--- End diff --
should this handler run on separate EventLoopGroup? since GetBlockData
might block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
