Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16867#discussion_r106235234
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -911,17 +919,16 @@ private[spark] class TaskSetManager(
override def checkSpeculatableTasks(minTimeToSpeculation: Int): Boolean
= {
// Can't speculate if we only have one task, and no need to speculate
if the task set is a
// zombie.
- if (isZombie || numTasks == 1) {
+ if (isZombie || numTasks == 1 || !speculationEnabled) {
--- End diff --
I don't think you need this change -- whether speculation is enabled is
checked before calling this function
(https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L177)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
