Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15009#discussion_r106243726
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
    @@ -107,6 +119,30 @@ public static void setConfig(String name, String 
value) {
         launcherConfig.put(name, value);
       }
     
    +  /**
    +   * Specifies that Spark Application be stopped if current process goes 
away.
    +   * It tries stop/kill Spark Application if {@link LauncherServer} goes 
away.
    +   *
    +   * @since 2.2.0
    +   * @return This launcher.
    +   */
    +  public SparkLauncher autoShutdown() {
    --- End diff --
    
    This is inconsistent with `launchAsThread` which takes a boolean. I think 
adding the parameter is better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to