Github user jsoltren commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14617#discussion_r106470033
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
    @@ -87,8 +87,13 @@ case class 
SparkListenerEnvironmentUpdate(environmentDetails: Map[String, Seq[(S
       extends SparkListenerEvent
     
     @DeveloperApi
    -case class SparkListenerBlockManagerAdded(time: Long, blockManagerId: 
BlockManagerId, maxMem: Long)
    -  extends SparkListenerEvent
    +case class SparkListenerBlockManagerAdded(
    +    time: Long,
    +    blockManagerId: BlockManagerId,
    +    maxMem: Long,
    +    maxOnHeapMem: Option[Long] = None,
    +    maxOffHeapMem: Option[Long] = None) extends SparkListenerEvent {
    +}
    --- End diff --
    
    I assume that, with this, we get JSON serialization of 
SparkListenerBlockManagerAdded events for free? It's important that an external 
history server be able to see the new maxOnHeapMem and maxOffHeapMem values.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to