GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/17331
[SPARK-19994][SQL] Wrong outputOrdering for right/full outer smj
## What changes were proposed in this pull request?
For right outer join, values of the left key will be filled with nulls if
it can't match the value of the right key, so `nullOrdering` of the left key
can't be guaranteed. We should output right key order.
For full outer join, neither left key nor right key guarantees
`nullOrdering`. We should not output any ordering.
This patch also reorganizes code in `PlannerSuite` by separating tests for
`Exchange` and `Sort`, and also extracts common logic in Sort tests into a
method.
## How was this patch tested?
Corresponding test cases added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wzhfy/spark wrongOrdering
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17331
----
commit 8dc2c046d32df84626470303ea97180a1091684b
Author: wangzhenhua <[email protected]>
Date: 2017-03-17T06:58:10Z
wrong outputOrdering for right/full outer smj
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
